Catch missed errors during instance initiation #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-level errors are bypassed by SWIG when calling `dlite.new_Instance()` and `dlite.Instance_swiginit()` since they are internal and not generated functions. Try to see if we can create normal error-catching wrappers around these functions.
jesper-friis
changed the title
jesper-friis
changed the title
jesper-friis
changed the title
francescalb
approved these changes
Oct 17, 2023
Comment added to the code clarifying the purpose of this PR. |
…o errors-in-instance_init
…o errors-in-instance_init
…o errors-in-instance_init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to catch missed errors in dlite.Instance.init()
C-level errors are bypassed by SWIG when calling
dlite.new_Instance()anddlite.Instance_swiginit()since they are internal and not generated functions.Try to see if we can create normal error-catching wrappers around these functions.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.