Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to Join Completed Producer Threads in Trace to Events #282

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Need to Join Completed Producer Threads in Trace to Events #282

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
007d31e
Need to join completed producer threads
Modularius Nov 28, 2024
143c120
Improved error message
Modularius Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions trace-to-events/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,18 +138,25 @@ async fn main() -> anyhow::Result<()> {
let mut kafka_producer_thread_set = JoinSet::new();

loop {
match consumer.recv().await {
Ok(m) => {
process_kafka_message(
&tracer,
&args,
&mut kafka_producer_thread_set,
&producer,
&m,
);
consumer.commit_message(&m, CommitMode::Async).unwrap();
tokio::select! {
msg = consumer.recv() => match msg {
Ok(m) => {
process_kafka_message(
&tracer,
&args,
&mut kafka_producer_thread_set,
&producer,
&m,
);
consumer.commit_message(&m, CommitMode::Async).unwrap();
}
Err(e) => warn!("Kafka error: {}", e)
},
join_next = kafka_producer_thread_set.join_next() => {
if let Some(Err(e)) = join_next {
error!("Error Joining Kafka Producer Task: {e}");
}
}
Err(e) => warn!("Kafka error: {}", e),
}
}
}
Expand Down