Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close hdf5 file after resuming or after errors occur #286

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Close hdf5 file after resuming or after errors occur #286

merged 3 commits into from
Dec 11, 2024

Conversation

Modularius
Copy link
Contributor

Summary of changes

Fixes two possible source of memory leakage:

  • Explicitly closes the hdf5 file after resuming a partial run
  • Explicitly closes the hdf5 file after an error occurs whilst reading or creating the datasets.

Instruction for review/testing

  • General code review.
  • Advice on limiting unnecessary memory usage.

@Modularius Modularius requested a review from DanNixon December 11, 2024 13:18
@Modularius Modularius changed the title Close hdf5 file when resuming Close hdf5 file after resuming or after errors occur Dec 11, 2024
DanNixon
DanNixon approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@DanNixon DanNixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanNixon DanNixon merged commit 0705b8f into STFC-ICD-Research-and-Design:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanNixon DanNixon DanNixon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Super-MuSR
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Modularius @DanNixon