Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update to swipl v9.1.17 #383

Closed
wants to merge 2 commits into from
Closed

fix: update to swipl v9.1.17 #383

wants to merge 2 commits into from

Conversation

jeswr
Copy link
Collaborator

@jeswr jeswr commented Oct 17, 2023

fix: update to swipl v9.1.17

@jeswr jeswr enabled auto-merge (squash) October 17, 2023 00:07
@jeswr
Copy link
Collaborator Author

jeswr commented Oct 17, 2023

@JanWielemaker We are failing to upgrade to swipl 9.1.17. The failing test is here and appears to be because the time library is not available in the WASM build.

Is this something that can easily be resolved in https://github.com/SWI-Prolog/swipl-devel?

@JanWielemaker
Copy link
Member

Sure. Pushed SWI-Prolog/swipl-devel@c9f050b.

This is not a new issue, no?

@jeswr
Copy link
Collaborator Author

jeswr commented Oct 18, 2023 •
edited
Loading

This is not a new issue, no?

This is the first time it's caused CI failures. Perhaps there a new ctest added that made use of the time module?

Unrelated note: Leaving this PR open until SWIPL v9.1.18 is released to avoid noise of this being re-opened by CI.

@JanWielemaker
Copy link
Member

I added some use_module directives to various tests. That might be a reason. Anyway, the test is now cleanly disabled if it cannot run.

@jeswr
Copy link
Collaborator Author

jeswr commented Nov 2, 2023

Closing as v9.1.18 is now available.

@jeswr jeswr closed this Nov 2, 2023
auto-merge was automatically disabled November 2, 2023 13:34

Pull request was closed

@jeswr jeswr deleted the fix/update-swipl-v9.1.17 branch November 2, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeswr @JanWielemaker