Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade react-dnd and react-dnd-html5-backend to v16 #7106

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: upgrade react-dnd and react-dnd-html5-backend to v16 #7106

wants to merge 1 commit into from
+47 −238

Conversation

Parsium
Copy link
Contributor

@Parsium Parsium commented Nov 28, 2024 •
edited
Loading

BREAKING CHANGE: Both packages are now ESM-only, which may affect tools like Jest that run your project code in a Node.js environment. Adjust your bundler configuration to handle ESM code if issues arise.

Proposed behaviour

Current behaviour

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

@Parsium
feat: upgrade react-dnd and react-dnd-html5-backend to v16
e4043de 
BREAKING CHANGE: Both packages are now ESM-only, which may affect tools like Jest
that run your project code in a Node.js environment. Adjust your bundler configuration
to handle ESM code if issues arise.
@Parsium Parsium self-assigned this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DipperTheDan DipperTheDan DipperTheDan approved these changes

@edleeks87 edleeks87 edleeks87 approved these changes

Assignees

@Parsium Parsium

Labels
DO NOT MERGE No QA Required No UX QA Required Passed Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Parsium @edleeks87 @DipperTheDan