feat: added punctuality display (#122) #473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # das_client/lib/app/pages/journey/train_journey/widgets/train_journey.dart # das_client/lib/model/journey/base_data.dart # das_client/lib/model/journey/datatype.dart # das_client/lib/model/journey/metadata.dart # das_client/lib/sfera/src/mapper/sfera_model_mapper.dart # das_client/lib/sfera/src/model/network_specific_parameter.dart # das_client/test/sfera/mapper/sfera_mapper_test.dart # das_client/test_resources/sp/SFERA_SP_9999_2.xml # das_client/test_resources/sp/SFERA_SP_9999_3.xml # das_client/test_resources/sp/SFERA_SP_9999_4.xml
# Conflicts: # das_client/integration_test/test/train_journey_table_test.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/additional_speed_restriction_row.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/base_row_builder.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/cab_signaling_row.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/cells/bracket_station_cell_body.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/cells/route_cell_body.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/protection_section_row.dart # das_client/lib/app/pages/journey/train_journey/widgets/table/service_point_row.dart # das_client/lib/app/pages/journey/train_journey/widgets/train_journey.dart # das_client/lib/model/journey/cab_signaling.dart # das_client/lib/model/journey/track_equipment.dart
…so added Duration into Metadata and changed the UI so that it only shows the delay from the metadata. Still have to check if it is needed to add hours
tobe-official
changed the title
# Conflicts: # das_client/test/sfera/mapper/sfera_mapper_test.dart
tobe-official
changed the title
rawi-coding
requested changes
Dec 20, 2024
das_client/lib/app/pages/journey/train_journey/widgets/header/time_container.dart
Outdated
Show resolved
Hide resolved
das_client/lib/app/pages/journey/train_journey/widgets/header/time_container.dart
Outdated
Show resolved
Hide resolved
| @@ -150,6 +159,20 @@ class SferaModelMapper { | |||
| ); | |||
| } | |||
|
|
|||
| static Duration _stringToDuration(String stringToChange) { | |||
There was a problem hiding this comment.
Ich würde diese Logik gleich im "Domain-Model" Delay führen, z.B. eine toDuration() Methode.
…ngIndicator does not work currently.
Grodien
reviewed
Jan 6, 2025
das_client/ios/Podfile.lock
Outdated
| @@ -68,4 +68,4 @@ SPEC CHECKSUMS: | |||
|
|
|||
| PODFILE CHECKSUM: d9dad56c0cd0b4fd8b4fe3034a53fd42a0b990f6 | |||
|
|
|||
| COCOAPODS: 1.16.1 | |||
| COCOAPODS: 1.15.2 | |||
There was a problem hiding this comment.
cocoapods bei dir noch updaten, dieser change reverten
Grodien
reviewed
Jan 6, 2025
das_client/lib/app/pages/journey/train_journey/widgets/header/time_container.dart
Outdated
Show resolved
Hide resolved
Grodien
reviewed
Jan 6, 2025
das_client/lib/app/pages/journey/train_journey/widgets/header/time_container.dart
Outdated
Show resolved
Hide resolved
Grodien
requested changes
Jan 6, 2025
Grodien
requested changes
Jan 14, 2025
| return validateHasAttribute('Delay') && super.validate(); | ||
| } | ||
|
|
||
| static Duration? toDuration(String? stringToChange) { |
There was a problem hiding this comment.
statt static methode wär es schöner einen getter wie "Duration? get delayAsDuration => " zu haben.
das_client/lib/app/pages/journey/train_journey/widgets/header/time_container.dart
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.