chore: Add cover page placeholder after applying webhooks, to exclude…

… possibility to break cover page logic Refs: #91
SchweizerischeBundesbahnen · Aug 20, 2024 · 883b416 · 883b416
1 parent 8f86895
commit 883b416
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/docs/openapi.json b/docs/openapi.json
@@ -1389,6 +1389,9 @@
           },
           "watermark": {
             "type": "boolean"
+          },
+          "webhooks": {
+            "type": "string"
           }
         },
         "type": "object"

diff --git a/src/main/java/ch/sbb/polarion/extension/pdf/exporter/converter/PdfConverter.java b/src/main/java/ch/sbb/polarion/extension/pdf/exporter/converter/PdfConverter.java
@@ -140,11 +140,13 @@ public byte[] convertToPdf(@NotNull ExportParams exportParams, @Nullable ExportM
             metaInfoCallback.setLinkedWorkItems(WorkItemRefData.extractListFromHtml(htmlContent, exportParams.getProjectId()));
         }
         htmlContent = htmlProcessor.internalizeLinks(htmlContent);
-        htmlContent = applyWebooks(exportParams, htmlContent);
-        return htmlContent;
+        htmlContent = applyWebhooks(exportParams, htmlContent);
+
+        // Add a fake page which later will be replaced with cover page. This should be done post-webhooks not to break this approach.
+        return (exportParams.getCoverPage() != null ? "<div style='break-after:page'>page to be removed</div>" : "") + htmlContent;
     }
 
-    private @NotNull String applyWebooks(@NotNull ExportParams exportParams, @NotNull String htmlContent) {
+    private @NotNull String applyWebhooks(@NotNull ExportParams exportParams, @NotNull String htmlContent) {
         if (exportParams.getWebhooks() == null) {
             return htmlContent;
         }
@@ -219,7 +221,6 @@ String composeHtml(@NotNull String documentName,
                                @NotNull HtmlData htmlData,
                                @NotNull ExportParams exportParams) {
         String content = htmlData.headerFooterContent
-                + (exportParams.getCoverPage() != null ? "<div style='break-after:page'>page to be removed</div>" : "") //add fake page which later will be replaced with title
                 + "<div class='content'>" + htmlData.documentContent + "</div>";
         return pdfTemplateProcessor.processUsing(exportParams, documentName, htmlData.cssContent, content);
     }