feat: refactor the object model and covert with unit tests

Refs: #312
SchweizerischeBundesbahnen · Dec 16, 2024 · c70814e · c70814e
1 parent c57ab6e
commit c70814e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/...in/java/ch/sbb/polarion/extension/pdf_exporter/rest/model/documents/DocumentBaseline.java b/...in/java/ch/sbb/polarion/extension/pdf_exporter/rest/model/documents/DocumentBaseline.java
@@ -2,6 +2,7 @@
 
 import com.polarion.alm.tracker.model.IBaseline;
 import lombok.Data;
+import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
 
 import java.util.ArrayList;
@@ -17,11 +18,6 @@ public DocumentBaseline(@Nullable String projectBaselineName, @Nullable String d
         this.documentBaselineName = documentBaselineName;
     }
 
-    public DocumentBaseline(@Nullable IBaseline projectBaseline, @Nullable IBaseline moduleBaseline) {
-        this.projectBaselineName = projectBaseline != null ? projectBaseline.getName() : null;
-        this.documentBaselineName = moduleBaseline != null ? moduleBaseline.getName() : null;
-    }
-
     public String asPlaceholder() {
         List<String> names = new ArrayList<>();
 
@@ -35,4 +31,11 @@ public String asPlaceholder() {
 
         return String.join(" | ", names);
     }
+
+    public static @NotNull DocumentBaseline from(@Nullable IBaseline projectBaseline, @Nullable IBaseline moduleBaseline) {
+        String projectBaselineName = projectBaseline != null ? projectBaseline.getName() : null;
+        String documentBaselineName = moduleBaseline != null ? moduleBaseline.getName() : null;
+        return new DocumentBaseline(projectBaselineName, documentBaselineName);
+    }
+
 }
diff --git a/...arion/extension/pdf_exporter/rest/model/documents/adapters/CommonUniqueObjectAdapter.java b/...arion/extension/pdf_exporter/rest/model/documents/adapters/CommonUniqueObjectAdapter.java
@@ -49,7 +49,7 @@ public abstract class CommonUniqueObjectAdapter implements IUniqueObjectAdapter
         IBaseline projectBaseline = baselinesManager.getRevisionBaseline(revision);
         IBaseline moduleBaseline = baselinesManager.getRevisionBaseline(getUniqueObject(), revision);
 
-        return new DocumentBaseline(projectBaseline, moduleBaseline);
+        return DocumentBaseline.from(projectBaseline, moduleBaseline);
     }
 
 }