-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul of SBBCheckbox #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanHoangTran
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this got a little bit bigger than expected 👀
This PR aligns the
SBBCheckbox
andSBBCheckboxListItem
to the design guidelines again, with backward compatibility (users might experience little layout changes).closes #215
What this PR adds:
SBBCheckbox
is painted using a CustomPainter in a check animated fashion as a person would draw it on a piece of paper - it uses theToggleableStateMixin
and thebuildToggeable
for the logic.SBBCheckbox
and theSBBCheckboxListItem
are aligned to the design specs (including actually respecting some of the colors previously not used (disabled colors)).SBBCheckboxListItem
is added.SBBCheckboxListItem
is added via a isLoading parameter - this displays an animated BottomLoadingIndicator sweeping through the tileSBBCheckbox
and theSBBCheckboxListItem
has been revised and completedSBBCheckbox
), merged with all the semantics of theSBBCheckboxListTile
The layout of the
SBBCheckbox
has been corrected.This is the design spec:
This was the old implementation with two stacked rounded rectangles:
The new loading indicator:
Screen.Recording.2025-01-08.at.09.23.28.mov