Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SBBSwitch: Overhaul #267

Merged
merged 6 commits into from
Jan 14, 2025
Merged

SBBSwitch: Overhaul #267

merged 6 commits into from
Jan 14, 2025

Conversation

smallTrogdor
Copy link
Contributor

@smallTrogdor smallTrogdor commented Jan 14, 2025 •
edited
Loading

This PR closes #254 and closes #234.

The allowMultilineLabel actually has an effect.
The isLoading argument is added.
The boxed variant is added

Tests are added.

Simulator Screenshot - iPhone 16 Pro - 2025-01-14 at 11 57 20

@smallTrogdor smallTrogdor requested a review from a team as a code owner January 14, 2025 10:58
@smallTrogdor smallTrogdor linked an issue Jan 14, 2025 that may be closed by this pull request
[Bug]: SBBSwitchListItem ignores allowMultilineLabel property #254
Closed
2 tasks
@smallTrogdor smallTrogdor merged commit 97074fd into main Jan 14, 2025
8 checks passed
@smallTrogdor smallTrogdor deleted the 254-bug-sbbswitchlistitem-ignores-allowmultilinelabel-property branch January 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanHoangTran VanHoangTran VanHoangTran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SBBSwitchListItem ignores allowMultilineLabel property [Review]: Switch review
2 participants
@smallTrogdor @VanHoangTran