Project Workflow - PMs should not be able to bypass Consultant checks for Internships #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that a single transition can have multiple states based on other things (like project state).
This opens the door for `from` field & generic abstraction
Disallow direct access to member values when referencing generically
```ts
let Color: MadeEnum<'red' | 'blue'>;
let AnEnum: MadeEnum<string>;
```
Without this change `Color` can't be assigned to `AnEnum`, because
the TS defines the member values as an index: `{ [x: string]: string }`.
So since one has an index accessor and one doesn't,
making them incompatible.
The `entry()` arg type change also allows them to be compatible.
Without it TS thinks something like `entry()` fn accepting any `string`
is not compatible with `entry()` fn only accepting `'red' | 'blue'`.
Using another generic at the function level somehow works around this,
while still maintaining all the strictness.
CarsonF
reviewed
Jun 7, 2024
| @@ -23,6 +24,45 @@ export const IsMultiplication: Condition = { | |||
| }, | |||
| }; | |||
|
|
|||
| export const hasValidRoleForProjectType: Condition = { | |||
There was a problem hiding this comment.
This is an authorization concern, so the policies should handle it. We need to just figure out how to get the "internship type condition" there. Let me think about it.
I get that it's kinda weird since we have two ways and both have conditions.
CarsonF
force-pushed
the
project-workflow
branch
5 times, most recently
from
84af753 to
b2e86fa
Compare
CarsonF
changed the title
|
This was actually implemented in 55777cd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday