fix(Item): actually make content a shorthand prop for ItemContent
#4118
Conversation
As already documented.
Codecov Report
@@ Coverage Diff @@
## master #4118 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3241 3246 +5
=======================================
+ Hits 3233 3238 +5
Misses 8 8
Continue to review full report at Codecov.
|
| contentShorthandValue === undefined && | ||
| [description, extra, header, meta].some((prop) => !_.isNil(prop)) | ||
| ) { | ||
| contentShorthandValue = {} |
There was a problem hiding this comment.
Only setting this when content is strictly undefined here and letting ItemContent.create handle everything else, because it allows the user to still use null (or a boolean) to prevent rendering when one of the other shorthands is set. Maybe true should also be included though?
| /> | ||
| {ItemContent.create(contentShorthandValue, { | ||
| autoGenerateKey: false, | ||
| overrideProps: { description, extra, header, meta }, |
There was a problem hiding this comment.
Alternatively you could use defaultProps here, but I think it makes sense for them to override because they're more 'specific'.
It says it is in the docs, but actually
Itemcurrently just forwards thecontentprop toItemContentlike a typical content prop. This PR will allow use ofas,classNameandverticalAlignvia shorthand, and is especially useful when providing theitemsarray shorthand toItemGroup.With this PR nothing changes for people who were using a primitive value, but it might be a breaking change if people were supplying an element or array, they would need to change it to
content={ content: <element /> }or similar to match previous behaviour.Also with this change
ItemContentwill no longer unconditionally render, at least one of the shorthands has to be present.