-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add "linkedin in" icon name to enumeration to fix console error #4471
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #4471 +/- ##
=======================================
Coverage ? 99.75%
=======================================
Files ? 180
Lines ? 3249
Branches ? 0
=======================================
Hits ? 3241
Misses ? 8
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Oops, I haven't mentioned that it targets v2 branch. @mwaddell I will cherry pick commit to |
Thank you @layershifter - I identified the issue in v2.1.5 which is why I targeted that branch - we haven't migrated any of our code to target 3.x yet since it's still in beta. |
fixes #4470 by adding the "linkedin in" name to the existing enumerations