Remove the cached provider functionality #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
force-pushed
the
remove-cached-provider
branch
from
a29d0c9 to
b8da614
Compare
loevgaard
force-pushed
the
remove-cached-provider
branch
from
b8da614 to
9de6028
Compare
Codecov ReportBase: 14.55% // Head: 14.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 2.x #99 +/- ##
============================================
- Coverage 14.55% 14.37% -0.18%
+ Complexity 241 223 -18
============================================
Files 37 36 -1
Lines 852 765 -87
============================================
- Hits 124 110 -14
+ Misses 728 655 -73
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
This functionality is only used when a user goes the shipping page then goes to some other page and ends up on the shipping page again. I reckon all this complexity is not necessary for such a small case.
Wdyt @vvasiloi?