Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miaz/schema name max length #834

Closed
wants to merge 2 commits into from
Closed

Conversation

miazbikowski
Copy link
Contributor

@miazbikowski miazbikowski commented Nov 4, 2024

As per the requested check:

When a schema name exceeds 25 characters, show an error message otherwise will encounter:  AssetCloud::AssetNotSaved: Validation failed: Invalid schema: name is too long (max 25 characters)

from this list.

Added a simple maxLength to the section and theme block JSON schemas.

Tested locally with theme-tools debug:

image

Edit: what if we have a translation? can its key be more than 25 chars? this isn't the right approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant