Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client readme example to compile with previous API changes #607

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

abecevello
Copy link
Member

Updates the full example in the client readme to compile. It was broken and didn't reflect the current API. I also removed an unnecessary example test that wasn't necessary to get a feel for how to use Toxiproxy.

Copy link

@mattbardal mattbardal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small suggestions but otherwise this looks good to me!

client/README.md Show resolved Hide resolved
client/README.md Show resolved Hide resolved
@abecevello abecevello merged commit 754b6b6 into main Dec 16, 2024
6 checks passed
@abecevello abecevello deleted the fix-client-readme-example branch December 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants