-
-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to net8 #2583
Update to net8 #2583
Conversation
src/ImageSharp.ruleset
Outdated
@@ -1,7 +1,11 @@ | |||
<?xml version="1.0" encoding="utf-8"?> | |||
<RuleSet Name="ImageSharp" ToolsVersion="17.0"> | |||
<Include Path="..\shared-infrastructure\sixlabors.ruleset" Action="Default" /> | |||
<Rules AnalyzerId="Microsoft.CodeAnalysis.CSharp.NetAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.CSharp.NetAnalyzers"> | |||
<Rule Id="CA1857" Action="None" /> | |||
<Rule Id="CA1859" Action="None" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://learn.microsoft.com/de-de/dotnet/fundamentals/code-analysis/quality-rules/ca1859
I disabled this to get a build without errors. I can remove it and fix all places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should open up a discussion or issue to track it so it's not forgotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had a hack at this. Only 3 changes required in private methods.
Thanks for this. You might want to put a pause on it though until we ship v3.1 We'll need to update SharedInfrastructure submodule following that. |
@JimBobSquarePants should we run the arm tests before we merge this? |
@stefannikolei triggered. |
src/ImageSharp/Memory/Allocators/Internals/SharedArrayPoolBuffer{T}.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me. Let's pull the trigger!
I just ran the JpegEncoder tests against .NET6 and .NET8. Those look promising.
|
Prerequisites
Description