-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed all occurenceas of var #2803
base: main
Are you sure you want to change the base?
Conversation
Thanks @stefannikolei I'm into this but we need to make sure two things are in place:
For example: RowInterval rows = new RowInterval(yMin, yMax); // ❌
RowInterval rows = new(yMin, yMax); // ✔️ The following rule will require updating to
In addition, we should add a new rule to enforce collection expressions with the same severity. |
* Also added Rider settings. Some Rules are not supported by Rider.
I tried to do that. I also Affen some Settins vor Rider. These Look good. Some of the editorconfig settings are not supported in rider. Therefore I could not really test those. Whe this looks good to you I can go forward and fix the stylecop errors. I always get bitten by the no errors in debug mode... |
I've merged the changes to the infrastructure repo so you should be good to continue |
Some build errors are false positives. A bug fix for StyleCop.Analyzer is already implemented but not yet released. |
@stefannikolei I've introduced a bunch of conflicts here. Do you want me to fix them or would you have time? |
Just let it sit until the StyleCopAnalyzers thing is figured out. Most changes were made by tooling and not by hand. |
To have a consistent code base I changed all usages of var and changed the editorconfig rule to error.
Do you want this things to be on error in the editorconfig?