Skip to content

Commit

Permalink
resolving weird pip issues, remove argparse as its built-in
Browse files Browse the repository at this point in the history
  • Loading branch information
flowstate committed Nov 7, 2024
1 parent b9b0d25 commit 923f9cc
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/pr-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,4 +130,5 @@ jobs:
tags: socketdev/cli:pr-${{ github.event.pull_request.number }}
build-args: |
CLI_VERSION=${{ env.VERSION }}
PIP_INDEX_URL=https://test.pypi.org/simple
PIP_INDEX_URL=https://test.pypi.org/simple
PIP_EXTRA_INDEX_URL=https://pypi.org/simple
12 changes: 4 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,11 @@ FROM python:3-alpine
LABEL org.opencontainers.image.authors="socket.dev"
ARG CLI_VERSION
ARG PIP_INDEX_URL=https://pypi.org/simple
ARG PIP_EXTRA_INDEX_URL=https://pypi.org/simple

RUN apk update \
&& apk add --no-cache git nodejs npm yarn

RUN pip install --index-url ${PIP_INDEX_URL} socketsecurity==$CLI_VERSION \
RUN pip install --index-url ${PIP_INDEX_URL} --extra-index-url ${PIP_EXTRA_INDEX_URL} socketsecurity==$CLI_VERSION \
&& socketcli -v \
&& socketcli -v | grep -q $CLI_VERSION

# !! Uncomment to test local build - requires running `python -m build` first (and correct version number)
# COPY dist/socketsecurity-1.0.34-py3-none-any.whl /tmp/
# RUN pip install /tmp/socketsecurity-1.0.34-py3-none-any.whl \
# && socketcli -v \
# && socketcli -v | grep -q $CLI_VERSION
&& socketcli -v | grep -q $CLI_VERSION
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ dependencies = [
'requests',
'mdutils',
'prettytable',
'argparse',
'GitPython',
'packaging',
]
Expand Down

0 comments on commit 923f9cc

Please sign in to comment.