TODOs and test cleanup

patchfinder/src/main/java/patches/PatchFinder.java

@@ -57,7 +57,7 @@ public class PatchFinder {
 	private static DatabaseHelper databaseHelper;
 	private static PatchUrlFinder patchURLFinder;
 
-	private static final ArrayList<PatchCommit> patchCommits = new ArrayList<>();
+	private static final Set<PatchCommit> patchCommits = new HashSet<>();
 	private static Map<String, ArrayList<String>> sourceDict;
 	protected static Instant urlDictLastCompilationDate = Instant.parse("2000-01-01T00:00:00.00Z");
 	protected static final String[] addressBases = PatchFinderEnvVars.getAddressBases();
@@ -173,7 +173,7 @@ public static int run(Map<String, CpeGroup> affectedProducts, int cveLimit) thro
 		PatchFinder.findPatchesMultiThreaded(possiblePatchURLs);
 
 		// Get found patches from patchfinder
-		ArrayList<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
+		Set<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
 
 		// Insert found patch commits (if any)
 		if(patchCommits.size() > 0) {
@@ -311,7 +311,7 @@ private static void writeSourceDict(String patchSrcUrlPath, Map<String, ArrayLis
 		}
 	}
 
-	public static ArrayList<PatchCommit> getPatchCommits() {
+	public static Set<PatchCommit> getPatchCommits() {
 		return patchCommits;
 	}
 

patchfinder/src/main/java/patches/PatchFinderThread.java

@@ -51,7 +51,8 @@ public class PatchFinderThread implements Runnable {
 	private final HashMap<String, ArrayList<String>> cvePatchEntry;
 	private final String clonePath;
 	private final long timeoutMilli;
-	private RevWalk walk; // TODO: initialize properly
+	private RevWalk walk; // TODO: remove
+	//TODO: Improve these patterns, currently we are getting many commits not directly related to the specific cve we claim
 	private static final Pattern[] patchPatterns = new Pattern[] {Pattern.compile("vulnerability|Vulnerability|vuln|Vuln|VULN[ #]*([0-9]+)")};
 	private static final Logger logger = LogManager.getLogger(PatchFinder.class.getName());
 

patchfinder/src/main/java/patches/PatchUrlFinder.java

@@ -110,6 +110,7 @@ public void parsePatchURLs(Map<String, ArrayList<String>> possiblePatchUrls, Map
 	 * @param vendor vendor name
 	 * @throws IOException if an IO error occurs while testing the url connection
 	 */
+	// TODO: Consider using https://www.cve.org to lookup existing github references to repos/PRs
 	private ArrayList<String> parseURL(String vendor, String product) throws IOException {
 		ArrayList<String> newAddresses = new ArrayList<>();
 

patchfinder/src/test/java/patches/PatchFinderTest.java

@@ -48,6 +48,7 @@ public class PatchFinderTest {
     @Before
     public void setUp() {
         PatchFinderEnvVars.initializeEnvVars(true);
+        PatchFinder.init();
     }
 
     @Test

patchfinder/src/test/java/patches/PatchFinderThreadTest.java

@@ -22,6 +22,7 @@
  * SOFTWARE.
  */
 
+import org.junit.Ignore;
 import patches.PatchCommit;
 import org.junit.Test;
 import org.mockito.Mockito;
@@ -32,6 +33,7 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
+import java.util.Set;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
@@ -44,6 +46,7 @@ public class PatchFinderThreadTest {
 
     //TODO: This needs to be re-written to utilize mocks. This test was failing because the apache airflow github added more patch commits
     @Test
+    @Ignore
     public void testRun() {
         HashMap<String, ArrayList<String>> cvePatchEntry = new HashMap<>();
         ArrayList<String> patchSources = new ArrayList<>();
@@ -57,7 +60,7 @@ public void testRun() {
 
         PatchFinder patchFinder = Mockito.mock(PatchFinder.class);
         //check the patch commits
-        List<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
+        Set<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
         assertEquals(48, patchCommits.size());
 
     }
@@ -79,7 +82,7 @@ public void testFindPatchCommitsFromUrl() {
 
         PatchFinder patchFinder = Mockito.mock(PatchFinder.class);
         //check the patch commits
-        List<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
+        Set<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
         assertEquals(0, patchCommits.size());
 
     }
@@ -96,7 +99,7 @@ public void testParseCommitObjects() throws IOException {
         PatchFinder.getPatchCommits().clear();
         //want parseCommitObjects to be called, so we have to check the url using findPatchCommitsFromUrl
         PatchFinder.findPatchesMultiThreaded(cvePatchEntry);
-        List<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
+        Set<PatchCommit> patchCommits = PatchFinder.getPatchCommits();
         assertEquals(0, patchCommits.size());
 
     }