Refactored PyPaYamlFile #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctevse
force-pushed
the
pypa-null-fix
branch
from
22e63c7 to
36778c9
Compare
- Moved initialization into a static from method - This separates how the object is created from what medium it can be created from - Changed get's to getOrDefaults - This allows nullpointers to be eaten and replaced with a default value - Removed affected and references - These are not used outside of parsing, so they should be removed - If they are needed in the future, we should parse them into proper objects, not the generic Object - Added tests to support the refactor
- This test needs to be rewritten since it performs querying of the actual webpage which changed and caused the assert to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152