Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lecturer ratings #122

Merged
merged 2 commits into from
Jan 5, 2025
Merged

feat: lecturer ratings #122

merged 2 commits into from
Jan 5, 2025

Conversation

olekszczepanowski
Copy link
Member

a wiec tak:
zmiany w schemacie bazki:

  • tabela lecturers (tam teraz są przechowywane dane prowadzacych i ich average ratingi)
  • tabela ratings( fundamencik pod wystawianie opinii 👍, bo nadal w sumie nie wiem co chcemy robic)
  • nowe tabele group_lecturers i group_archive_lecturers
  • zmiany juz w istniejacych tabelach

zmiany w kontrolerach:

  • wszystko co zawiera grupy zostało zmienione, front nie wymaga zmian poza wyświetlaniem ratingów (zakładam ze na razie bedzie po prostu jako np. 4.23 tak jak na polwro)

zmiany w scraperze i powiadomieniach

qamarq
qamarq approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@qamarq qamarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mega zajebista robota, jeśli śmiga wszystko poprawnie to 🚀

backend/app/controllers/schedules_controller.ts Show resolved Hide resolved
D0dii
D0dii reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@D0dii D0dii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Będzie pewnie trzeba ogarnąć migracji na produkcji, bo coś czuję, że się popsują

backend/app/controllers/courses_controller.ts Show resolved Hide resolved
backend/app/controllers/courses_controller.ts Show resolved Hide resolved
backend/app/controllers/groups_controller.ts Show resolved Hide resolved
backend/app/controllers/schedules_controller.ts Outdated Show resolved Hide resolved
backend/app/models/lecturer.ts Show resolved Hide resolved
backend/commands/notifications.ts Show resolved Hide resolved
@olekszczepanowski olekszczepanowski merged commit 9cbbe34 into main Jan 5, 2025
1 check passed
@olekszczepanowski olekszczepanowski deleted the lecturers-ratings branch January 5, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D0dii D0dii D0dii left review comments

@qamarq qamarq qamarq approved these changes

@unewMe unewMe Awaiting requested review from unewMe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olekszczepanowski @qamarq @D0dii