-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Include Kubernetes version in helm template #243
Conversation
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
@chess-knight While reviewing this PR, I noticed that a new flag was added without a strong reason behind it. Of course, I understand that this may seem convenient when using a third-party dependency. |
The reason is the cilium helm chart, which doesn't work for k8s < 1.30 when installation is done by
Yes, this is true. |
Hi @chess-knight and @janiskemper since this is approved, can it be merged? |
IMHO yes |
yes |
It is strange. One unit test failed, but I merged only docs changes. Before that change, all tests passed. |
I was successful in re-running ;) |
What this PR does / why we need it:
Helm charts can use
Capabilities.KubeVersion
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes SovereignCloudStack/cluster-stacks#143
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: