Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix issue 231: Continue if cluster stack string is invalid #254

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Sep 3, 2024

What this PR does / why we need it:

If a release in the Github repo is not following the correct naming pattern of cluster stack releases, then up to now the the process failed.

This PR creates a Kuberentes Event, and then continues with the next release of the list.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #231

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Signed-off-by: Thomas Guettler <thomas.guettler@syself.com>
@guettli guettli force-pushed the tg/fix-issue-231-continue-if-cluster-stack-string-is-invalid branch from 6c1cd9e to c6b6d3f Compare September 3, 2024 08:33
@guettli guettli requested a review from janiskemper September 3, 2024 08:36
@chess-knight
Copy link
Member

chess-knight commented Sep 3, 2024

Hi there, I hit the similar problem and proposed a solution here fba490d#diff-83f84407fa1b782bedd13dbe38772704c2516be07f1509b512ea481bcd84bc5d. What do you think about releases without name? I took TagName instead of Name.

I am also thinking about logic like take Name and if it doesn't exist, take TagName.

@guettli
Copy link
Contributor Author

guettli commented Sep 3, 2024

Hi there, I hit the similar problem and proposed a solution here fba490d#diff-83f84407fa1b782bedd13dbe38772704c2516be07f1509b512ea481bcd84bc5d. What do you think about releases without name? I took TagName instead of Name.

I am also thinking about logic like take Name and if it doesn't exist, take TagName.

Since releases don't get created by hand, I think the current logic (to use name) is fine.

@janiskemper what do you think?

@chess-knight But this is a different topic. Maybe open an issue or PR about that, so we can discuss this at the appropriate place.

@chess-knight
Copy link
Member

Since releases don't get created by hand, I think the current logic (to use name) is fine.

Yeah, you are right, but still, the name of the release is not required by GitHub API https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release.

But you are right, let's discuss it elsewhere.

@chess-knight chess-knight mentioned this pull request Sep 3, 2024
3 tasks
@janiskemper
Copy link
Member

this should be a solution to the problem. We can, as you two probably concluded as well, think about possible improvements at another place!

@janiskemper janiskemper merged commit a45cc0d into main Sep 4, 2024
6 checks passed
@janiskemper janiskemper deleted the tg/fix-issue-231-continue-if-cluster-stack-string-is-invalid branch September 4, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore irrelevent or wrong releases in autosubscribe
3 participants