-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 add docs for releasing cluster-stack-operator #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @kranurag7, is that still a Draft? |
I wanted to add a note and I've done that via 94b951a Now, I'll mark this ready for review. |
Thanks @kranurag7. Question to you and @batistein (as requested for review): are those approvals still up-to-date? If yes, please merge. EDIT: sorry, hit return accidentely |
Signed-off-by: kranurag7 <anurag.kumar@syself.com>
Signed-off-by: kranurag7 <anurag.kumar@syself.com>
94b951a
to
76681e2
Compare
Yes, I think the approvals are still up to date here but still let's go through it again. @chess-knight @michal-gubricky I added on more commit about updating metadata.yaml when we change the minor version for the release. Please review it again and upon approval, let's get this patch merged into main. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #62
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: