-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 udpate to CAPI 1.6.0 #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschoone
added
the
Container
Issues or pull requests relevant for Team 2: Container Infra and Tooling
label
Feb 27, 2024
Merged
kranurag7
force-pushed
the
syself/update-to-capi-1.6.0
branch
from
March 3, 2024 09:53
f22519a
to
0789970
Compare
@janiskemper tests are failing because of caching, you can verify this on your local system as well. $ make test-unit
go install sigs.k8s.io/controller-runtime/tools/setup-envtest@v0.0.0-20230620070423-a784ee78d04b
go install gotest.tools/gotestsum@v1.10.0
curl -sSL https://get.helm.sh/helm-v3.12.2-linux-amd64.tar.gz | tar xz -C hack/tools/bin --strip-components=1 linux-amd64/helm
chmod a+rx /home/k7/work/scsoss/cluster-stack-operator/hack/tools/bin/helm
CREATE_KIND_CLUSTER=true KUBEBUILDER_ASSETS="/home/k7/work/scsoss/cluster-stack-operator/hack/tools/bin/k8s/1.25.0-linux-amd64" /home/k7/work/scsoss/cluster-stack-operator/hack/tools/bin/gotestsum --junitfile=.coverage/junit.xml --format testname -- -mod=vendor \
-covermode=atomic -coverprofile=.coverage/cover.out -p=4 ./internal/controller/...
PASS internal/controller.TestMakeDiff (0.00s)
PASS internal/controller.TestGetLatestReadyClusterStackRelease/a_ready,_latest_cluster_stack_release_present (0.00s)
PASS internal/controller.TestGetLatestReadyClusterStackRelease/No_ready_cluster_stack_releases (0.00s)
PASS internal/controller.TestGetLatestReadyClusterStackRelease (0.00s)
PASS internal/controller.TestGetUsableClusterStackReleaseVersions/two_ready_cluster_stack_releases (0.00s)
PASS internal/controller.TestGetUsableClusterStackReleaseVersions/no_ready_cluster_stack_releases (0.00s)
PASS internal/controller.TestGetUsableClusterStackReleaseVersions (0.00s)
PASS internal/controller.TestGetClusterStackReleasesInSpec (0.00s)
PASS internal/controller.TestControllers (307.10s)
coverage: 51.1% of statements
PASS internal/controller (coverage: 51.1% of statements)
DONE 9 tests in 333.114s |
janiskemper
approved these changes
Mar 4, 2024
I think it makes sense to use 1.6.2 instead? Then the version would be directly up to date. |
the goal would be to let this be done by renovate bot automatically ;) Otherwise you are completely right that we should make it up to date even in this PR |
kranurag7
force-pushed
the
syself/update-to-capi-1.6.0
branch
from
March 8, 2024 10:40
479eeb5
to
c17062a
Compare
this commit updates to CAPI 1.6.0 Signed-off-by: kranurag7 <anurag.kumar@syself.com>
kranurag7
force-pushed
the
syself/update-to-capi-1.6.0
branch
from
March 12, 2024 10:19
a67b349
to
c477415
Compare
janiskemper
approved these changes
Mar 12, 2024
kranurag7
pushed a commit
that referenced
this pull request
Apr 24, 2024
…-1.6.0 🌱 udpate to CAPI 1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit updates to cluster API 1.6.0
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #77
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: