🐛 fix upgrade builder image script #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when I initially worked on this, this was hardcoded and we were using grep + sed combination to get version. Later we switched to track version by using a file at the root of the repo. The file was .builder-image-version.txt, this was a bug where we were still reading from Makefile hardcoded version. This commit fixes the same and switches to new method where we read from .builder-image-version.txt Signed-off-by: kranurag7 <anurag.kumar@syself.com>
batistein
approved these changes
Feb 28, 2024
kranurag7
added a commit
that referenced
this pull request
Apr 24, 2024
…ilder-image-script 🐛 fix upgrade builder image script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I initially worked on this, this was hardcoded and we were using grep + sed combination to get
version. Later we switched to track version by
using a file at the root of the repo.
The file was .builder-image-version.txt, this was
a bug where we were still reading from Makefile
hardcoded version.
This commit fixes the same and switches to new
method where we read from .builder-image-version.txt