Create a GitHub client before mutex

Signed-off-by: Roman Hros <roman.hros@dnation.cloud>

internal/controller/openstackclusterstackrelease_controller.go

@@ -123,12 +123,6 @@ func (r *OpenStackClusterStackReleaseReconciler) Reconcile(ctx context.Context,
 	if download {
 		conditions.MarkFalse(openstackclusterstackrelease, apiv1alpha1.ClusterStackReleaseAssetsReadyCondition, apiv1alpha1.ReleaseAssetsNotDownloadedYetReason, clusterv1beta1.ConditionSeverityInfo, "assets not downloaded yet")
 
-		// this is the point where we download the release from github
-		// acquire lock so that only one reconcile loop can download the release
-		r.openStackClusterStackRelDownloadDirectoryMutex.Lock()
-
-		defer r.openStackClusterStackRelDownloadDirectoryMutex.Unlock()
-
 		gc, err := r.GitHubClientFactory.NewClient(ctx)
 		if err != nil {
 			conditions.MarkFalse(openstackclusterstackrelease,
@@ -144,6 +138,12 @@ func (r *OpenStackClusterStackReleaseReconciler) Reconcile(ctx context.Context,
 
 		conditions.MarkTrue(openstackclusterstackrelease, apiv1alpha1.GitAPIAvailableCondition)
 
+		// this is the point where we download the release from github
+		// acquire lock so that only one reconcile loop can download the release
+		r.openStackClusterStackRelDownloadDirectoryMutex.Lock()
+
+		defer r.openStackClusterStackRelDownloadDirectoryMutex.Unlock()
+
 		if err := downloadReleaseAssets(ctx, releaseTag, releaseAssets.LocalDownloadPath, gc); err != nil {
 			logger.Error(err, "failed to download release assets")
 			return ctrl.Result{RequeueAfter: 1 * time.Minute}, nil