Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add hash mode compatibility #108

Merged
merged 3 commits into from
Feb 27, 2024
Merged

✨ Add hash mode compatibility #108

merged 3 commits into from
Feb 27, 2024

Conversation

matofeder
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #99

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@cluster-stack-bot cluster-stack-bot bot added the size/M Denotes a PR that changes 50-200 lines, ignoring generated files. label Feb 26, 2024
@matofeder matofeder force-pushed the hash_mode branch 2 times, most recently from 36c01c0 to 34d53b1 Compare February 26, 2024 14:17
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you never work with the version itself, so that this is enough?

@matofeder
Copy link
Member Author

do you never work with the version itself, so that this is enough?

CSPO does not take the CS version into account right now. It takes the node image name from the node-images.yaml and uploads it to OpenStack.
Hence images with the same name could be consumed by CSs in different versions.

This should be improved, and IMO CSO should take the node-image version (metadata) into account, somehow. But this is not trivial and will be discussed in a separate issue.

@janiskemper
Copy link
Member

okay! Then I guess someone should test the whole workflow starting from generating a hash release with csctl and then see whether it works with cso and cspo!
Code-wise it looks alright to me, but the change is also very small. Therefore testing will be more important I guess!

@michal-gubricky
Copy link
Contributor

okay! Then I guess someone should test the whole workflow starting from generating a hash release with csctl and then see whether it works with cso and cspo! Code-wise it looks alright to me, but the change is also very small. Therefore testing will be more important I guess!

Today, I tested the entire workflow, beginning with the use of csctl to generate a hash release with the local_mode set to cspo and cso. It seems to be working; I found no error logs in either controller, and all cluster-stack resources were ready.

@janiskemper
Copy link
Member

sounds great!

@matofeder matofeder merged commit c6a4caf into main Feb 27, 2024
6 checks passed
@matofeder matofeder deleted the hash_mode branch February 27, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support hash mode/custom channel in CSPO
3 participants