-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add hash mode compatibility #108
Conversation
36c01c0
to
34d53b1
Compare
Signed-off-by: Matej Feder <matej.feder@dnation.cloud>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you never work with the version itself, so that this is enough?
CSPO does not take the CS version into account right now. It takes the node image name from the node-images.yaml and uploads it to OpenStack. This should be improved, and IMO CSO should take the node-image version (metadata) into account, somehow. But this is not trivial and will be discussed in a separate issue. |
okay! Then I guess someone should test the whole workflow starting from generating a hash release with csctl and then see whether it works with cso and cspo! |
Today, I tested the entire workflow, beginning with the use of csctl to generate a hash release with the local_mode set to cspo and cso. It seems to be working; I found no error logs in either controller, and all cluster-stack resources were ready. |
sounds great! |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #99
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: