Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Code cleanup #13

Merged
merged 3 commits into from
Jan 24, 2024
Merged

🌱 Code cleanup #13

merged 3 commits into from
Jan 24, 2024

Conversation

NotTheEvilOne
Copy link
Contributor

What this PR does / why we need it:

This PR cleans up most basic scaffold traces in the code.

@cluster-stack-bot cluster-stack-bot bot added the size/M Denotes a PR that changes 50-200 lines, ignoring generated files. label Dec 18, 2023
@NotTheEvilOne NotTheEvilOne force-pushed the prs/initial-code-cleanup branch from 3622aeb to 4c51e6e Compare December 19, 2023 13:27
cmd/main.go Outdated Show resolved Hide resolved
@NotTheEvilOne NotTheEvilOne force-pushed the prs/initial-code-cleanup branch from 4c51e6e to e263d87 Compare December 21, 2023 05:33
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NotTheEvilOne
I see this PR still as a valid and useful one, just please resolve conflicts and rebase on the latest main. Then we can review it. Thx

Signed-off-by: Tobias Wolf <wolf@b1-systems.de>
@NotTheEvilOne NotTheEvilOne force-pushed the prs/initial-code-cleanup branch from e263d87 to 25c6ca6 Compare January 17, 2024 08:53
@NotTheEvilOne
Copy link
Contributor Author

Done. It's not much that's left thought :)

@matofeder matofeder self-requested a review January 17, 2024 08:54
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chess-knight chess-knight merged commit 36591a1 into main Jan 24, 2024
6 checks passed
@chess-knight chess-knight deleted the prs/initial-code-cleanup branch January 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants