✨ Support specifying the CA cert or adding verify=false into clouds.yaml #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-gubricky
force-pushed
the
support-disable-tls-verification
branch
from
cd90634 to
94275b2
Compare
michal-gubricky
force-pushed
the
support-disable-tls-verification
branch
from
94275b2 to
71fcbca
Compare
cluster-stack-bot
bot
added
the
size/M
michal-gubricky
force-pushed
the
support-disable-tls-verification
branch
from
0ec913f to
069440b
Compare
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
support-disable-tls-verification
branch
from
069440b to
2de04a8
Compare
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Co-authored-by: Roman Hros <roman.hros@dnation.cloud> Signed-off-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Based on the discussion in matrix chat, see here. We would like to support a scenario where AuthURL in clouds.yaml is not signed by the public authority like e.g. Let's Encrypt. This can be resolved by specify the CA certificate or adding verify: false into your clouds.yaml file. CAPO already implemented here.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #146
TODOs: