-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Replace quickstart document by a link #152
Merged
michal-gubricky
merged 4 commits into
main
from
docs/replace-quickstart-by-link-to-new-quickstart
May 31, 2024
Merged
📖 Replace quickstart document by a link #152
michal-gubricky
merged 4 commits into
main
from
docs/replace-quickstart-by-link-to-new-quickstart
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there are two quickstart documents. This is very confusing. There should only be one quickstart. This commit replaces the quickstart document in this repository with a link to the current quickstart document in the cluster-stacks repository. Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
jklippel
changed the title
Replace quickstart document by a link
Docs: 📖 Replace quickstart document by a link
Apr 18, 2024
jklippel
changed the title
Docs: 📖 Replace quickstart document by a link
📖 Replace quickstart document by a link
Apr 18, 2024
michal-gubricky
requested changes
May 30, 2024
Co-authored-by: Michal Gubricky <michal.gubricky@dnation.cloud> Signed-off-by: jklippel <jklippel@users.noreply.github.com>
cluster-stack-bot
bot
added
the
size/M
Denotes a PR that changes 50-200 lines, ignoring generated files.
label
May 30, 2024
Co-authored-by: Michal Gubricky <michal.gubricky@dnation.cloud> Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
Hi @michal-gubricky, do you have to do anything here or is it a bug in GitHub? Because I can't see any unresolved change requests |
Everything seems to be resolved from my side now after you have applied my second suggestion as well. |
michal-gubricky
approved these changes
May 31, 2024
michal-gubricky
deleted the
docs/replace-quickstart-by-link-to-new-quickstart
branch
May 31, 2024 05:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two quickstart documents.
This is very confusing. There should only be
one quickstart.
This commit replaces the quickstart document in
this repository with a link to the current quickstart document in the cluster-stacks repository.