Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Replace quickstart document by a link #152

Merged

Conversation

jklippel
Copy link
Contributor

Currently there are two quickstart documents.
This is very confusing. There should only be
one quickstart.

This commit replaces the quickstart document in
this repository with a link to the current quickstart document in the cluster-stacks repository.

Currently there are two quickstart documents.
This is very confusing. There should only be
one quickstart.

This commit replaces the quickstart document in
this repository with a link to the current quickstart
document in the cluster-stacks repository.

Signed-off-by: Jan Klippel <jan.klippel@uhurutec.com>
@jklippel jklippel requested review from jschoone and paulphys April 17, 2024 14:26
@jklippel jklippel changed the title Replace quickstart document by a link Docs: 📖 Replace quickstart document by a link Apr 18, 2024
@jklippel jklippel changed the title Docs: 📖 Replace quickstart document by a link 📖 Replace quickstart document by a link Apr 18, 2024
@jklippel jklippel self-assigned this Apr 29, 2024
@jschoone jschoone requested a review from michal-gubricky May 30, 2024 07:37
docs/quickstart.md Outdated Show resolved Hide resolved
docs/quickstart.md Outdated Show resolved Hide resolved
Co-authored-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: jklippel <jklippel@users.noreply.github.com>
@jklippel jklippel requested a review from michal-gubricky May 30, 2024 10:47
@cluster-stack-bot cluster-stack-bot bot added the size/M Denotes a PR that changes 50-200 lines, ignoring generated files. label May 30, 2024
jschoone and others added 2 commits May 30, 2024 17:53
Co-authored-by: Michal Gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
@jschoone
Copy link
Contributor

Hi @michal-gubricky, do you have to do anything here or is it a bug in GitHub? Because I can't see any unresolved change requests

@michal-gubricky
Copy link
Contributor

Hi @michal-gubricky, do you have to do anything here or is it a bug in GitHub? Because I can't see any unresolved change requests

Everything seems to be resolved from my side now after you have applied my second suggestion as well.

@michal-gubricky michal-gubricky merged commit 5f53f97 into main May 31, 2024
5 checks passed
@michal-gubricky michal-gubricky deleted the docs/replace-quickstart-by-link-to-new-quickstart branch May 31, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants