Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 remove goconst and goimports #18

Merged
merged 1 commit into from
Dec 19, 2023
Merged

🌱 remove goconst and goimports #18

merged 1 commit into from
Dec 19, 2023

Conversation

kranurag7
Copy link
Contributor

remove goconst and goimports from golangci config. This also adds revive
latest config.

Signed-off-by: Anurag anurag.kumar@syself.com

@cluster-stack-bot cluster-stack-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/hack Changes made in the hack directory area/github Changes made in the github directory labels Dec 19, 2023
remove goconst and goimports from golangci config. This also adds revive
latest config.

Signed-off-by: Anurag <anurag.kumar@syself.com>
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kranurag7 thanks for this fix!

@matofeder matofeder merged commit 4693c2d into main Dec 19, 2023
6 checks passed
@matofeder matofeder deleted the kr/fix-linting-errors branch December 19, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github Changes made in the github directory area/hack Changes made in the hack directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants