✨ Add identityRef and cloudName into OpenStackClusterStackReleaseSpec #21
Conversation
cluster-stack-bot
bot
added
size/M
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
michal-gubricky
force-pushed
the
feat/spec-indentityref
branch
from
326c038 to
bc39a36
Compare
| CloudName string `json:"cloudName"` | ||
|
|
||
| // IdentityRef is a reference to a identity to be used when reconciling this cluster | ||
| IdentityRef OpenStackIdentityReference `json:"identityRef,omitempty"` |
There was a problem hiding this comment.
In the CAPO, there is *OpenStackIdentityReference, whats the difference?
There was a problem hiding this comment.
If I am correct * in go is a pointer to the specified type. I think the primary difference is whether IdentityRef is a pointer or a direct instance of OpenStackIdentityReference. Using a pointer allows the possibility of a null value, while using an actual instance does not.
There was a problem hiding this comment.
Thank you, and why you don't use a pointer?
There was a problem hiding this comment.
I think, it is up to us. If we want to have possibility of a null value for this field or not.
There was a problem hiding this comment.
I think that it can also speed up code when we work with references so the object doesn't need to be copied
|
|
||
| // OpenStackIdentityReference is a reference to an infrastructure | ||
| // provider identity to be used to provision cluster resources. | ||
| type OpenStackIdentityReference struct { |
There was a problem hiding this comment.
It is somehow possible to import this type from CAPO?
There was a problem hiding this comment.
I can check if it is possible
There was a problem hiding this comment.
Hey, I think you can import existing types, but let's do it after kubernetes-sigs/cluster-api-provider-openstack#1797 to reduce dependencies.
There was a problem hiding this comment.
The mentioned PR is merged in CAPO v1alpha8
There was a problem hiding this comment.
IMO this PR could be closed on behalf of #23.
Once CAPO v1alpha8 is available https://pkg.go.dev/sigs.k8s.io/cluster-api-provider-openstack@v0.9.0/api then the renovate bot will do this job for us and reduce CAPO dependencies.
|
Closed in favor of #23 |
It is a common pattern in capo