Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Make metrics endpoints on control plane nodes available for monitoring #142

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

michal-gubricky
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #127

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@michal-gubricky michal-gubricky force-pushed the feat/metrics-endpoints branch 4 times, most recently from 9801c10 to 37e3a51 Compare July 22, 2024 13:03
@michal-gubricky michal-gubricky marked this pull request as ready for review July 22, 2024 13:04
@michal-gubricky michal-gubricky force-pushed the feat/metrics-endpoints branch from 37e3a51 to e687140 Compare July 22, 2024 13:05
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
Signed-off-by: michal.gubricky <michal.gubricky@dnation.cloud>
@michal-gubricky michal-gubricky force-pushed the feat/metrics-endpoints branch from e687140 to 5adce82 Compare July 22, 2024 13:31
@chess-knight chess-knight requested a review from Nils98Ar July 22, 2024 14:15
Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Nils98Ar Nils98Ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@michal-gubricky michal-gubricky merged commit 5b2f3f0 into main Jul 23, 2024
2 checks passed
@michal-gubricky michal-gubricky deleted the feat/metrics-endpoints branch July 23, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make metrics endpoints on control plane nodes available for monitoring
3 participants