-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop k8s <= v1.20.x #643
Drop k8s <= v1.20.x #643
Conversation
k8s: * v1.28.1 -> v1.28.3 * v1.27.5 -> v1.27.7 * v1.26.8 -> v1.26.10 * v1.25.13 -> v1.25.15 Drop versions v1.19.x and v1.18.x occm/csi: * v1.28.0 -> v1.28.1 * v1.27.2 -> v1.27.3 * v1.26.3 -> v1.26.4 Also drop stuff prior to v1.20. Signed-off-by: Kurt Garloff <kurt@garloff.de>
Testing remarks:
Backporting remark:
|
Doesn't it make sense to automate this using Renovate/CI? In osism/k8s-capi-images with use https://github.com/osism/k8s-capi-images/blob/main/src/update-extra-vars.py for this task. Retrieves the current versions and then updates them in the corresponding files. |
I manually added |
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 30m 22s Warning: Sonobouy results=== Collecting results === time="2023-11-14T15:29:38Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2023-11-14T15:29:38Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2023-11-14T15:29:38Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: systemd-logs Status: passed Total: 4 Passed: 4 Failed: 0 Skipped: 0Plugin: e2e Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2023-11-14 15:29:43 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also remove support for k8s < 1.26? Based on "SCS K8S Version Policy" it is RECOMMENDED to not support versions after this period in order to not encourage usage of out-of-date versions.
[1]
# Conflicts: # terraform/files/bin/openstack-kube-versions.inc
Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Always download 'master' Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Hello @garloff, @NotTheEvilOne
I think this is reasonable and can be done in the future PR for sure |
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 20m 11s Warning: Sonobouy results=== Collecting results === time="2024-01-15T08:56:38Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-01-15T08:56:38Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-15T08:56:38Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7072 Passed: 4 Failed: 0 Skipped: 7068Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-15 08:56:44 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 5m 26s Warning: Custom ENV config
|
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 3m 57s Warning: Custom ENV config
|
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 34m 35s Warning: Sonobouy results=== Collecting results === time="2024-01-23T13:54:55Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-01-23T13:54:55Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-23T13:54:55Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7072 Passed: 4 Failed: 0 Skipped: 7068Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-23 13:55:00 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
Build failed (e2e-quick-test pipeline). ❌ k8s-cluster-api-provider-e2e-quick FAILURE in 5m 02s Warning: Custom ENV config
|
Build succeeded (e2e-quick-test pipeline). ✔️ k8s-cluster-api-provider-e2e-quick SUCCESS in 38m 12s Warning: Sonobouy results=== Collecting results === time="2024-01-24T21:06:15Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-01-24T21:06:15Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-24T21:06:15Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" Plugin: e2e Status: passed Total: 7072 Passed: 4 Failed: 0 Skipped: 7068Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 5 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 4 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-24 21:06:21 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Custom ENV config
|
Build succeeded (e2e-test pipeline). ✔️ k8s-cluster-api-provider-e2e-conformance SUCCESS in 2h 34m 33s Warning: Sonobouy results=== Collecting results === time="2024-01-26T11:45:26Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=sonobuoy time="2024-01-26T11:45:26Z" level=info msg="delete request issued" dry-run=false kind=clusterrolebindings names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-26T11:45:26Z" level=info msg="delete request issued" dry-run=false kind=clusterroles names="[sonobuoy-serviceaccount-sonobuoy]" time="2024-01-26T11:45:26Z" level=info msg="delete request issued" dry-run=false kind=namespace namespace=webhook-447 Plugin: e2e Status: passed Total: 7213 Passed: 382 Failed: 0 Skipped: 6831Plugin: systemd-logs Run Details: Namespace "sonobuoy" has status {Phase:Terminating Conditions:[{Type:NamespaceDeletionDiscoveryFailure Status:False LastTransitionTime:2024-01-26 11:45:32 +0000 UTC Reason:ResourcesDiscovered Message:All resources successfully discovered} {Type:NamespaceDeletionGroupVersionParsingFailure Status:False LastTransitionTime:2024-01-26 11:45:32 +0000 UTC Reason:ParsedGroupVersions Message:All legacy kube types successfully parsed} {Type:NamespaceDeletionContentFailure Status:False LastTransitionTime:2024-01-26 11:45:32 +0000 UTC Reason:ContentDeleted Message:All content successfully deleted, may be waiting on finalization} {Type:NamespaceContentRemaining Status:True LastTransitionTime:2024-01-26 11:45:32 +0000 UTC Reason:SomeResourcesRemain Message:Some resources are remaining: pods. has 1 resource instances} {Type:NamespaceFinalizersRemaining Status:False LastTransitionTime:2024-01-26 11:45:32 +0000 UTC Reason:ContentHasNoFinalizers Message:All content-preserving finalizers finished}]} Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [webhook-447] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [webhook-447] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [webhook-447] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [webhook-447] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. Found 1 namespaces that still need to be deleted: [webhook-447] Namespace "sonobuoy" has been deleted Deleted all ClusterRoles and ClusterRoleBindings. All E2E namespaces deleted Custom ENV config
|
Nice. |
k8s:
Drop versions v1.19.x and v1.18.x
occm/csi:
Also drop stuff prior to v1.20.
Edit:
min_snapshot_master
logic - no more need as the logic was for k8s < v1.21.0