Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acc. to scs-0102-v1, os_hash_algo is recommended. #410

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Acc. to scs-0102-v1, os_hash_algo is recommended. #410

merged 1 commit into from
Dec 18, 2023

Conversation

garloff
Copy link
Member

@garloff garloff commented Dec 18, 2023

So let's not error out, but just display a warning. Also don't gate using non-recommended names with verbose setting, but display these warnings as well. Capitalize displayed suggested name.

@garloff
Acc. to scs-0102-v1, os_hash_algo is recommended.
127678e 
So let's not error out, but just display a warning.
Also don't gate using non-recommended names with verbose setting,
but display these warnings as well. Capitalize displayed
suggested name.

Signed-off-by: Kurt Garloff <kurt@garloff.de>
@garloff
Copy link
Member Author

garloff commented Dec 18, 2023

Note: Normally, upon registering an image, OpenStack does calculate an os_hash_value and sets it and os_hash_algo accordingly. However, according to the letter of scs-0102-v1 we only recommend and do not require it. So we can't error out upon a missing os_hash_algo.
This caused a spurious PCO IaaS SCS-compatible check failure for the image plusKI CUDA 12.1.
@costelter - You might still want to look into why your image has no os_hash_* values set.

@garloff garloff merged commit e9590ed into main Dec 18, 2023
3 checks passed
@garloff garloff deleted the fix/os_hash-is-recommended branch December 18, 2023 14:55
@garloff garloff added IaaS Issues or pull requests relevant for Team1: IaaS standards Issues / ADR / pull requests relevant for standardization & certification labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkr fkr fkr approved these changes

@mbuechse mbuechse Awaiting requested review from mbuechse

@costelter costelter Awaiting requested review from costelter

Assignees
No one assigned
Labels
IaaS Issues or pull requests relevant for Team1: IaaS standards Issues / ADR / pull requests relevant for standardization & certification
Projects
Sovereign Cloud Stack
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garloff @fkr