-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Jira module #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refresh!
Looks like the CI is failing for this change. Per https://pypi.org/project/jira/ it Requires: Python >=3.8, while the CI runs python 3.6. That's why the CI fails for this PR. I'm not sure if we have an easy way for resolving this
|
Yeah, hrm, Python 3.6 has been EoL for a while -- what's the story around Python versions and StackStorm packs, in general? |
We need to support both 3.6 and 3.8 so far and so the paks should ideally work with those. The reason is that with the current OS matrix we support (EL7, EL8, U18, U20), one of those OSes is still on py3.6 (I think U18?). BTW it was a topic for discussion in the last TSC meeting (StackStorm/community#114) and likely will be a difficulty to solve for the next release. So the Python version matrix is something we should keep in mind. |
Yeah, makes sense ... I maintain Ansible things, so, I'm aware of this pain 😄 |
We should get 3.8 and 3.10 added to the pack build and test matrix, eh? |
Definitely would be nice adding py3.8 to the packs build matrix as that's de-facto supported by StackStorm (https://github.com/StackStorm/st2/blob/9d0be4e2c3a906c3eab75164e1664f15ab2efb69/.github/workflows/ci.yaml#L153-L176) For py3.10, we need to ensure the StackStorm core could be built with that version first: |
I opened a Draft PR if you want to have the conversation there... |
We also need to support python 3.9 as RHEL drop support on El8 for python 3.8 next year - but will support python 3.9. |
@armab What are we doing about this, waiting for Python 3.6 to age out? |
Is there a version of the Jira pack that works with both py3.6 and py3.8? Otherwise, let's try https://peps.python.org/pep-0508/#environment-markers to specify different Jira versions depending on the python version. |
Looks like the last version to support Python 3.6 is 3.2.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks.
At moment investigating how much work involved in supporting python 3.9 and 3.10. 3.9 looks like just one issue with astroid/pylint, 3.10 - quite a lot! |
Update the Jira module to
3.2.0
and freshen up theREADME.md
; fixes #48.