Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested reusable workflow #41

Merged

Conversation

philippzagar
Copy link
Contributor

@philippzagar philippzagar commented Nov 9, 2023

Fix nested reusable workflow

♻️ Current situation & Problem

The original PR #40 contained an issue that reusable workflows must specify the full path of the nested reusable workflow in order to work properly. Furthermore, one must pay attention to where the JSON decoding of the runs-on arguments is done.

⚙️ Release Notes

  • Fixes an issue with the newly introduced XCFramework reusable workflow

📚 Documentation

--

✅ Testing

--

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar self-assigned this Nov 9, 2023
@philippzagar philippzagar requested review from Supereg and removed request for PSchmiedmayer November 9, 2023 19:18
@philippzagar philippzagar merged commit 4049326 into main Nov 9, 2023
2 checks passed
@philippzagar philippzagar deleted the feat/add-archive-and-xcframework-template-workflows branch November 9, 2023 19:19
@PSchmiedmayer
Copy link
Member

Thank you for the fix @philippzagar and thank you for the review @Supereg!
Is there a way that we can catch these things earlier so we don't release broken workflows? Can you verity that the current setup is working in a separate repo @philippzagar, I suspect this is StanfordBDHG/ResearchKit#9?

@philippzagar
Copy link
Contributor Author

@PSchmiedmayer I thought I actually verified the workflow (from within the feature branch) in https://github.com/StanfordBDHG/ResearchKit, but apparently, I messed something up, that's completely my fault. Will definitely be more careful here in the future to not merge a broken functionality.
And yes, the current setup is working in StanfordBDHG/ResearchKit#9 and is used there to create an XCFramework and a release.

@PSchmiedmayer
Copy link
Member

No worries, thank you for fixing this so fast!

I think we should think how we can automate some these tests in this repo to ensure that we don't run into this in the future, I created and updated an issue for this: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants