-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested reusable workflow #41
Fix nested reusable workflow #41
Conversation
…rkflows Signed-off-by: Philipp Zagar <zagar@stanford.edu>
…-template-workflows' into feat/add-archive-and-xcframework-template-workflows
Thank you for the fix @philippzagar and thank you for the review @Supereg! |
@PSchmiedmayer I thought I actually verified the workflow (from within the feature branch) in https://github.com/StanfordBDHG/ResearchKit, but apparently, I messed something up, that's completely my fault. Will definitely be more careful here in the future to not merge a broken functionality. |
No worries, thank you for fixing this so fast! I think we should think how we can automate some these tests in this repo to ensure that we don't run into this in the future, I created and updated an issue for this: #19 |
Fix nested reusable workflow
♻️ Current situation & Problem
The original PR #40 contained an issue that reusable workflows must specify the full path of the nested reusable workflow in order to work properly. Furthermore, one must pay attention to where the JSON decoding of the
runs-on
arguments is done.⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: