-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Dependencies #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; thank you @LeonNissen!
I think there is a build error due to a bump of XCTextExtensions (dismissKeyboard
argument) that needs to be fixed before the merge.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 93.03% 93.35% +0.32%
==========================================
Files 24 27 +3
Lines 832 931 +99
==========================================
+ Hits 774 869 +95
- Misses 58 62 +4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for the updates @LeonNissen!
2af4b75
to
cdfabc4
Compare
Update (as discuss with @vishnuravi): Will wait for StanfordSpezi/SpeziLLM#81 to be merged since it fixes a bug running the local LLM on the simulator. |
The fix for running the local LLM in a simulator has been merged (thank you @LeonNissen), so we can merge this PR. The UI tests are flaky, they pass locally for both myself and @LeonNissen but fail intermittently on the runner. |
All checks passed except for patch coverage, which we cannot increase further at the moment, due to the changes in this PR being related to SpeziLLMLocal, which does not run on iOS simulators in its latest version (see README for details). Therefore, we will merge despite the patch coverage check not passing. |
Bump Dependencies
⚙️ Release Notes
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: