Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Dependencies #41

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Bump Dependencies #41

merged 6 commits into from
Dec 29, 2024

Conversation

LeonNissen
Copy link
Contributor

@LeonNissen LeonNissen commented Dec 12, 2024

Bump Dependencies

⚙️ Release Notes

  • Updates all dependencies
  • Uses new SpeziLLM Version 0.9.0 with MLX support
  • GPT 4o can be selected

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you @LeonNissen!

I think there is a build error due to a bump of XCTextExtensions (dismissKeyboard argument) that needs to be fixed before the merge.

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 93.35%. Comparing base (10b725e) to head (e603876).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
HealthGPT/HealthGPT/HealthGPTView.swift 54.55% 5 Missing ⚠️
HealthGPT/HealthGPT/HealthDataInterpreter.swift 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   93.03%   93.35%   +0.32%     
==========================================
  Files          24       27       +3     
  Lines         832      931      +99     
==========================================
+ Hits          774      869      +95     
- Misses         58       62       +4     
Files with missing lines Coverage Δ
HealthGPT/HealthGPT/SettingsView.swift 97.71% <100.00%> (+7.34%) ⬆️
...althGPT/Helper/CodableArray+RawRepresentable.swift 0.00% <ø> (ø)
HealthGPT/Onboarding/LLMLocalDownload.swift 75.00% <100.00%> (ø)
HealthGPT/Onboarding/OpenAIModelSelection.swift 100.00% <100.00%> (ø)
HealthGPTUITests/HealthGPTViewUITests.swift 100.00% <100.00%> (ø)
HealthGPT/HealthGPT/HealthDataInterpreter.swift 96.88% <75.00%> (-3.12%) ⬇️
HealthGPT/HealthGPT/HealthGPTView.swift 92.71% <54.55%> (-4.88%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778d271...e603876. Read the comment docs.

@vishnuravi vishnuravi self-requested a review December 13, 2024 03:00
Copy link
Member

@vishnuravi vishnuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the updates @LeonNissen!

@vishnuravi vishnuravi force-pushed the feature/bump-packages branch from 2af4b75 to cdfabc4 Compare December 14, 2024 17:22
@LeonNissen
Copy link
Contributor Author

Update (as discuss with @vishnuravi): Will wait for StanfordSpezi/SpeziLLM#81 to be merged since it fixes a bug running the local LLM on the simulator.

@vishnuravi
Copy link
Member

vishnuravi commented Dec 24, 2024

The fix for running the local LLM in a simulator has been merged (thank you @LeonNissen), so we can merge this PR. The UI tests are flaky, they pass locally for both myself and @LeonNissen but fail intermittently on the runner.

@vishnuravi vishnuravi merged commit 9863ef9 into main Dec 29, 2024
@vishnuravi vishnuravi deleted the feature/bump-packages branch December 29, 2024 13:21
@vishnuravi
Copy link
Member

vishnuravi commented Dec 29, 2024

All checks passed except for patch coverage, which we cannot increase further at the moment, due to the changes in this PR being related to SpeziLLMLocal, which does not run on iOS simulators in its latest version (see README for details). Therefore, we will merge despite the patch coverage check not passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants