Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OMHModels to a separate package #11

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Move OMHModels to a separate package #11

merged 4 commits into from
Oct 14, 2023

Conversation

vishnuravi
Copy link
Member

@vishnuravi vishnuravi commented Oct 14, 2023

Move OMHModels to a separate package

♻️ Current situation & Problem

The models found in the OMHModels target should be broken out into a separate Swift package so they can be used in other projects.

💡 Proposed solution

OMHModels has now been split into a separate Swift package, and we will import it here.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@vishnuravi vishnuravi changed the title Switches to using separate OMHModels package Move OMHModels to a separate package Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #11 (c504b62) into main (92e38af) will increase coverage by 4.85%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #11      +/-   ##
===========================================
+ Coverage   95.16%   100.00%   +4.85%     
===========================================
  Files          24         1      -23     
  Lines         351       106     -245     
===========================================
- Hits          334       106     -228     
+ Misses         17         0      -17     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e38af...c504b62. Read the comment docs.

@vishnuravi vishnuravi merged commit 97ff57e into main Oct 14, 2023
6 checks passed
@vishnuravi vishnuravi deleted the move-omhmodels branch October 14, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant