Fix modules resolution #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
Branches 1 1
=========================================
Hits 6 6 Continue to review full report in Codecov by Sentry.
|
arkadiuszbachorski
force-pushed
the
arek/fix-modules-resolution
branch
from
59fc21c to
e1b9844
Compare
PSchmiedmayer
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modules resolution
♻️ Current situation & Problem
Currently modules aren't properly resolved. There is a mix between two approaches. We have build process and package.json link of local file, but result of this operation isn't used. Actually, TS alias is used, which in the end works exactly like if we just imported relatively from
packagesdirectory.⚙️ Release Notes
📚 Documentation
This PR changes from TS alias to import of the actual package. Now, this resembles using 3rd party package, but it's stored in monorepo. It makes it bulletproof to move a package to separate repo without a lot of modifications.
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: