Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed showing price total for items in cart response #638

Open
wants to merge 2 commits into
base: 1.5
Choose a base branch
from
Open

Fixed showing price total for items in cart response #638

wants to merge 2 commits into from

Conversation

antonioperic
Copy link
Contributor

No description provided.

@antonioperic antonioperic requested a review from a team as a code owner February 26, 2020 22:35
@antonioperic antonioperic changed the title Fixed showing price total for items in response Fixed showing price total for items in cart response Feb 26, 2020
@antonioperic
Copy link
Contributor Author

fixes #637

@Zales0123 Zales0123 added the Bug label Feb 27, 2020
@mamazu
Copy link
Member

mamazu commented Apr 28, 2020

I just added a BC Break, as it is modifying a property and changing its value.

@mamazu mamazu mentioned this pull request Feb 21, 2021
Merged
lchrusciel added a commit that referenced this pull request Feb 23, 2021
@lchrusciel
feature #700 Adding a subtotal property to the cart endpoint (mamazu)
45b02bf 
This PR was merged into the 1.0-dev branch.

Discussion
----------

This partially solves #638 but without the BC break.

Commits
-------

038fd18 Adding a subtotal property to the cart endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonioperic @mamazu @Zales0123