Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

581 update admin UI implementation to make meta functionality reusable #583

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

581 update admin UI implementation to make meta functionality reusable #583

wants to merge 8 commits into from

Conversation

bnouwt
Copy link
Collaborator

@bnouwt bnouwt commented Dec 20, 2024

No description provided.

@bnouwt
Refactor AdminUI to extract MetaKB functionality for reuse.
d2c62c4 
Unit tests still succeed
@bnouwt
Merge branch 'master' into
cdcc557 
581-update-admin-ui-implementation-to-make-meta-functionality-reusable
@bnouwt bnouwt linked an issue Dec 20, 2024 that may be closed by this pull request
Update Admin UI implementation to make meta functionality reusable. #581
Open
@bnouwt
Remove unused config property definition.
d2cd835
@bnouwt
Correct wrong merge.
95b4a9e
@bnouwt
Update javadoc.
0e9a356
@bnouwt
Improve naming of MetaKB and MockedKnowledgeBase
636132c
@bnouwt
Some additional changes.
a283fbe 
WARNING: double check the phaser and stuff that was removed/added to the
MetadataKB because it is unclear how to do this.

Done:
- move some members from private -> protected
- change name to metadata
@bnouwt
Make sure the admin ui starts its knowledgebase.
ab50dbb
@bnouwt bnouwt requested a review from Sophietje January 7, 2025 15:24
@bnouwt
Copy link
Collaborator Author

bnouwt commented Jan 7, 2025

@Sophietje I've added you as a reviewer, but some additional remarks:

  • More information on the objective of this PR can be found in the associated issue Update Admin UI implementation to make meta functionality reusable. #581.
  • I've (again) sneaked in an irrelevant name change to the MockedKnowledgeBase class, because it is no longer only used to mock. Since this class was used in many places, this causes a lot of files with changes. Just focus on the admin-ui module for the changes relevant to this issue 😄

@bnouwt bnouwt self-assigned this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sophietje Sophietje Awaiting requested review from Sophietje

Assignees

@bnouwt bnouwt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Admin UI implementation to make meta functionality reusable.
1 participant
@bnouwt