fix: revert better alphanumeric sort of bools and floats (fix #5108) (#…

…5109) (#5129) This reverts commit 3f9d382.
TanStack · Oct 13, 2023 · 02a7884 · 02a7884
1 parent e4ddee6
commit 02a7884
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 90 deletions.
diff --git a/packages/table-core/__tests__/Sorting.test.ts b/packages/table-core/__tests__/Sorting.test.ts
diff --git a/packages/table-core/src/sortingFns.ts b/packages/table-core/src/sortingFns.ts
@@ -55,9 +55,6 @@ function compareBasic(a: any, b: any) {
 }
 
 function toString(a: any) {
-  if (typeof a === 'boolean') {
-    return String(a)
-  }
   if (typeof a === 'number') {
     if (isNaN(a) || a === Infinity || a === -Infinity) {
       return ''
@@ -74,13 +71,6 @@ function toString(a: any) {
 // It handles numbers, mixed alphanumeric combinations, and even
 // null, undefined, and Infinity
 function compareAlphanumeric(aStr: string, bStr: string) {
-  // Check if the string contains only a number
-  const aFloat = parseFloat(aStr);
-  const bFloat = parseFloat(bStr);
-  if(!isNaN(aFloat) && !isNaN(bFloat)) {
-    return compareBasic(aFloat, bFloat)
-  }
-
   // Split on number groups, but keep the delimiter
   // Then remove falsey split values
   const a = aStr.split(reSplitAlphaNumeric).filter(Boolean)