Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Framework text colour with v2 docs layout #150

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Jan 23, 2024

Currently, for the v2 layout (form/store), the react and "core" docs have text coloured, while other frameworks have their background coloured. I think this was a bug, so I've changed it so text is coloured - here is the difference.

Before:

image

After:

image

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tanstack-com ✅ Ready (Inspect) Visit Preview Jan 23, 2024 11:24pm

Copy link
Contributor

@fulopkovacs fulopkovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, I thought these were intentional, but I did find the taste of the designer rather peculiar... 🤣

@lachlancollins lachlancollins merged commit ac08936 into main Jan 24, 2024
4 checks passed
@lachlancollins lachlancollins deleted the fix-framework-text branch January 24, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants