Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ru_ru.json #2

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Create ru_ru.json #2

merged 3 commits into from
Jul 2, 2024

Conversation

mpustovoi
Copy link
Contributor

Why is ${mod_id} here instead of clientsort?

@mpustovoi
Create ru_ru.json
fdcc264 
Why is `${mod_id}` here instead of `clientsort`?
@NotRyken
Copy link
Member

NotRyken commented Jul 1, 2024 •
edited
Loading

Why is ${mod_id} here instead of clientsort?

That gets automatically replaced by the mod id (clientsort), the only real advantage is that it makes copying translations between different mods slightly easier.

@NotRyken
Copy link
Member

NotRyken commented Jul 1, 2024

I've made a few more things translatable in 9cc3310, if you can update your pr accordingly I'd be happy to merge it for the v0.5.0 release.

@mpustovoi
Copy link
Contributor Author

Done.

@NotRyken NotRyken merged commit 6a5e5b2 into TerminalMC:mc1.21 Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpustovoi @NotRyken