Fix GitHub pages #191
Open
Fix GitHub pages #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `peaceiris/actions-gh-pages` README describes, the `permissions / contents / write` definition is required. In other hand, without that, the step will fail. Also a jump to the version 4 is recommended. Basically because i did a test and previous version, as-is doesn't work.
|
Thanks a lot for the fix @Zen0x7 and sorry for the late review! The changes look good, however it seems that GitHub Actions are not starting running in this PR for some reason, even after merging with main. Could it be that you need to enable Actions on your fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
peaceiris/actions-gh-pagesREADME describes:is required. In other hand, without that, the step will fail.
Also a jump to the version 4 is recommended.
Basically because i did a test on the action without this change, just doesn't work:
Anyways, thanks so much @TheLartians.