PP-663 (Partial): Reduce logging volume (#257)

* Stop logging account icons. * It is possible for book database entries to disappear before syncs.
ThePalaceProject · Nov 10, 2023 · 2a3380a · 2a3380a
1 parent 19c4d00
commit 2a3380a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...ookmarks/src/main/java/org/nypl/simplified/bookmarks/internal/BServiceOpSyncOneAccount.kt b/...ookmarks/src/main/java/org/nypl/simplified/bookmarks/internal/BServiceOpSyncOneAccount.kt
@@ -170,6 +170,15 @@ internal class BServiceOpSyncOneAccount(
           bookmark.bookmarkId.value
         )
 
+        if (!syncable.account.bookDatabase.books().contains(bookmark.book)) {
+          this.logger.debug(
+            "[{}]: we no longer have book {}",
+            this.profile.id.uuid,
+            bookmark.bookmarkId.value
+          )
+          continue
+        }
+
         val entry = syncable.account.bookDatabase.entry(bookmark.book)
 
         when (bookmark) {

diff --git a/simplified-ui-images/src/main/java/org/nypl/simplified/ui/images/ImageAccountIcons.kt b/simplified-ui-images/src/main/java/org/nypl/simplified/ui/images/ImageAccountIcons.kt
@@ -28,8 +28,6 @@ object ImageAccountIcons {
     iconView: ImageView,
   ) {
     val uri = account.logoURI?.hrefURI
-    this.logger.debug("configuring account logo: {}", uri)
-
     if (uri == null) {
       iconView.setImageResource(defaultIcon)
       return