Skip to content

Commit

Permalink
Fixed Audiobook UI freezing after pressing 'play' (#236)
Browse files Browse the repository at this point in the history
* Fixed Audiobook UI freezing after pressing 'play'

* Updated libraries
  • Loading branch information
nunommts authored Oct 9, 2023
1 parent 0e0ccf8 commit 7cf1f37
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 6 deletions.
5 changes: 3 additions & 2 deletions README-CHANGES.xml
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@
<c:change date="2023-08-12T00:00:00+00:00" summary="Fixed crash when time tracking is not enabled."/>
</c:changes>
</c:release>
<c:release date="2023-09-26T13:54:16+00:00" is-open="true" ticket-system="org.nypl.jira" version="1.6.0">
<c:release date="2023-10-07T13:46:32+00:00" is-open="true" ticket-system="org.nypl.jira" version="1.6.0">
<c:changes>
<c:change date="2023-08-24T00:00:00+00:00" summary="Updated Kotlin version to 1.9.0"/>
<c:change date="2023-08-28T00:00:00+00:00" summary="Fixed crash when opening an audiobook with a null manifest."/>
Expand Down Expand Up @@ -328,7 +328,8 @@
</c:change>
<c:change date="2023-09-21T00:00:00+00:00" summary="Added support to EPUB text searching."/>
<c:change date="2023-09-22T00:00:00+00:00" summary="Added push notifications option to DEV settings."/>
<c:change date="2023-09-26T13:54:16+00:00" summary="Fixed bookmarks not being deleted."/>
<c:change date="2023-09-26T00:00:00+00:00" summary="Fixed bookmarks not being deleted."/>
<c:change date="2023-10-07T13:46:32+00:00" summary="Fixed Audiobook UI freezing after pressing 'play'."/>
</c:changes>
</c:release>
</c:releases>
Expand Down
2 changes: 1 addition & 1 deletion org.thepalaceproject.android.platform
3 changes: 3 additions & 0 deletions simplified-app-palace/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,7 @@ dependencies {
implementation(libs.kotlinx.coroutines.android)
implementation(libs.kotlinx.coroutines.core.jvm)
implementation(libs.kotlinx.coroutines.play.services)
implementation(libs.kotlinx.datetime)
implementation(libs.logback.android)
implementation(libs.moznion.uribuildertiny)
implementation(libs.nano.httpd)
Expand Down Expand Up @@ -608,4 +609,6 @@ dependencies {
implementation(libs.truevfs.driver.zip)
implementation(libs.truevfs.kernel.impl)
implementation(libs.truevfs.kernel.spec)
implementation(libs.ulid.kotlin)
implementation(libs.ulid.kotlin.jvm)
}
4 changes: 3 additions & 1 deletion simplified-books-time-tracking/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ dependencies {
implementation(project(":simplified-services-api"))

implementation(libs.irradia.mime.api)
implementation(libs.kotlinx.datetime)
implementation(libs.jackson.core)
implementation(libs.jackson.databind)
implementation(libs.joda.time)
Expand All @@ -17,5 +18,6 @@ dependencies {
implementation(libs.rxandroid2)
implementation(libs.rxjava2)
implementation(libs.slf4j)
implementation(libs.ulid.generator)
implementation(libs.ulid.kotlin)
implementation(libs.ulid.kotlin.jvm)
}
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ class TimeTrackingService(
.account(AccountID(UUID.fromString(timeTrackingInfo.accountId)))
)
} catch (exception: Exception) {
logger.error("Error while saving time tracking info remotely: ", exception)

// in case an exception occurs, we keep the original time entries
timeTrackingInfo.timeEntries
}
Expand Down
6 changes: 4 additions & 2 deletions simplified-tests/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,10 @@ val dependencyObjects = listOf(
libs.junit.jupiter.vintage,
libs.junit.platform.commons,
libs.junit.platform.engine,
libs.kotlinx.coroutines,
libs.kotlin.reflect,
libs.kotlin.stdlib,
libs.kotlinx.coroutines,
libs.kotlinx.datetime,
libs.logback.classic,
libs.logback.core,
libs.mockito.android,
Expand Down Expand Up @@ -293,7 +294,8 @@ val dependencyObjects = listOf(
libs.truevfs.driver.zip,
libs.truevfs.kernel.impl,
libs.truevfs.kernel.spec,
libs.ulid.generator,
libs.ulid.kotlin,
libs.ulid.kotlin.jvm,
)

dependencies {
Expand Down

0 comments on commit 7cf1f37

Please sign in to comment.